Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update animation slice bug #10

Open
Vardner opened this issue Nov 14, 2019 · 1 comment
Open

Update animation slice bug #10

Vardner opened this issue Nov 14, 2019 · 1 comment

Comments

@Vardner
Copy link

Vardner commented Nov 14, 2019

When animation is completed and activates onComplete callback, which removes other animation array "list" and array this.easings becomes different. After that action list have an element which this.easing doesn't. After that coming splice with index -1 and removes wrong animation element

proofs
after we delete element animation
image
and now we deleting index -1, so wrong element lost animation
image

@davidfig
Copy link
Owner

are you deleting the easing within the update loop of another easing? this was a chicken-and-egg problem that i tried to solve by ensuring all easings run regardless of what happens within the update loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants