Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

social: make selection and order of social share buttons configurable #60

Open
davidsneighbour opened this issue Feb 7, 2022 · 2 comments
Open

social: make selection and order of social share buttons configurable #60

davidsneighbour opened this issue Feb 7, 2022 · 2 comments
Assignees
@davidsneighbour
Labels
module:social state:confirmed This issue is confirmed. type:documentation Improvements or additions to docs. type:enhancement New enhancements and features.

Comments

@davidsneighbour
Copy link
Owner

davidsneighbour commented Feb 7, 2022 •
edited
Loading

  • add data configuration for shares ✔️
  • add local configuration object to site.Params ✔️ 
    [params.dnb.social]
[params.dnb.social.sharebuttons]
icons = true
sharetext = true
networks = ["facebook", "twitter", "linkedin"]
  • add partials for share buttons ✔️
  • sort items by networks configuration ✔️
  • enable/disable items by `networks configuration ✔️
  • write up documentation ❗
@davidsneighbour davidsneighbour self-assigned this Feb 7, 2022
davidsneighbour referenced this issue in davidsneighbour/hugo-social Feb 7, 2022
@davidsneighbour
feat: add share buttons
4867182 
see #16
davidsneighbour referenced this issue in davidsneighbour/hugo-social Feb 8, 2022
@davidsneighbour
feat: add network selection via configuration
b876406 
see #16 via @jmooring on https://discourse.gohugo.io/t/intersect-keys-in-dict-with-slice/37030/2?u=davidsneighbour
davidsneighbour referenced this issue in davidsneighbour/hugo-social Feb 8, 2022
@davidsneighbour
feat: sort networks by order in the configuration slice
70fff82 
see #16
@davidsneighbour
Copy link
Owner Author

@all-contributors add @jmooring for code

@allcontributors allcontributors bot mentioned this issue Feb 8, 2022
Merged
@allcontributors
Copy link

@davidsneighbour

I've put up a pull request to add @jmooring! 🎉

@davidsneighbour davidsneighbour changed the title Make selection and order of social share buttons configurable hugo-social: make selection and order of social share buttons configurable Apr 3, 2023
@davidsneighbour davidsneighbour transferred this issue from davidsneighbour/hugo-social Apr 3, 2023
@davidsneighbour davidsneighbour added state:unconfirmed This issue needs to be reproduced. module:social and removed enhancement labels Aug 4, 2024
@davidsneighbour davidsneighbour changed the title hugo-social: make selection and order of social share buttons configurable social: make selection and order of social share buttons configurable Aug 10, 2024
@davidsneighbour davidsneighbour added state:confirmed This issue is confirmed. type:documentation Improvements or additions to docs. type:enhancement New enhancements and features. and removed state:unconfirmed This issue needs to be reproduced. labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidsneighbour davidsneighbour

Labels
module:social state:confirmed This issue is confirmed. type:documentation Improvements or additions to docs. type:enhancement New enhancements and features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidsneighbour