Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableSourceMaps is not working in firefox #227

Closed
Jonesie opened this issue Feb 19, 2021 · 8 comments
Closed

enableSourceMaps is not working in firefox #227

Jonesie opened this issue Feb 19, 2021 · 8 comments
Labels

Comments

@Jonesie
Copy link

Jonesie commented Feb 19, 2021

In FireFox Im seeing mangled requests to main.map in the console. Works ok in Chrome. According to the angular people, this is coming from ngx-logger. Not a show stopped but strange.

See angular/angular-cli#20085

@bmtheo
Copy link
Collaborator

bmtheo commented Feb 19, 2021

EDIT : Editing my response as I missunderstood

According to @Jonesie the getMapFilePath of mapper.service.ts returns an invalid URL (ex : https://test.barxui.com/__tryOrUnsub@https://test.barxui.com/main-es2015.a9bb1bb8eb67a9f41008.js.map instead of just https://test.barxui.com/main-es2015.a9bb1bb8eb67a9f41008.js.map I suppose)
And this happens only on Firefox since he installed Angular 11

I'll dive into this and see how we can fix it

@bmtheo bmtheo added need more info More info is needed to act on the issue Needs investigation Issue will be investigated and removed need more info More info is needed to act on the issue labels Feb 19, 2021
@Jonesie
Copy link
Author

Jonesie commented Feb 20, 2021

Yes, turning source maps off fixes it.
Actually, having it turned on is not much use either, I guess because it didnt load:

image

In Chrome it works fine:
image

I should only have them turned on for dev mode.

@Jonesie
Copy link
Author

Jonesie commented Feb 20, 2021

Also worth noting, I had ngx-logger before NG 11 but it wasnt configured or used correct so probably nothing to do with the NG 11 update. Maybe.

@bmtheo bmtheo changed the title Weird request for map enableSourceMapsis not working in firefox Feb 20, 2021
@bmtheo bmtheo changed the title enableSourceMapsis not working in firefox enableSourceMaps is not working in firefox Feb 20, 2021
@bmtheo
Copy link
Collaborator

bmtheo commented Feb 20, 2021

Ok just tested on last version of firefox (85.0.2) and I get the same results so I renamed your issue

(It's working fine on Chrome and Edge)

@bmtheo bmtheo added bug and removed Needs investigation Issue will be investigated labels Feb 21, 2021
@bmtheo bmtheo closed this as completed in ef73ec3 Feb 22, 2021
bmtheo added a commit that referenced this issue Feb 22, 2021
Fixes #227 enableSourceMaps is not working in firefox
@Jonesie
Copy link
Author

Jonesie commented Feb 22, 2021

Nice work! Thank you :)

@Jonesie
Copy link
Author

Jonesie commented Feb 22, 2021

Oh, actually, I don't think it's fixed. I updated to 4.2.0 using FF 85.0.2 and still the same console error :/ I can deploy my test site again later.

@bmtheo
Copy link
Collaborator

bmtheo commented Feb 22, 2021

It's normal it was not part of the last publish, @qortex is on the next publish

If you want the fix faster, you need to checkout the repo and build it yourself so you can ref the package locally

@Jonesie
Copy link
Author

Jonesie commented Feb 22, 2021

Ok, no worries. I'll be more patient :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants