From 9bfc73adeb3a5eb4d701affd689e98dd8d53229b Mon Sep 17 00:00:00 2001 From: academy-codex Date: Sat, 17 Jul 2021 12:44:01 +0530 Subject: [PATCH 1/2] remove unused method; --- .../plugin/sybase/TestingSybaseServer.java | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestingSybaseServer.java b/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestingSybaseServer.java index e9685f5878b7..abf230c9e732 100644 --- a/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestingSybaseServer.java +++ b/plugin/trino-sybase/src/test/java/io/trino/plugin/sybase/TestingSybaseServer.java @@ -90,22 +90,4 @@ public void execute(String sql, String user, String password) throw new RuntimeException(e); } } - - public ResultSet executeQuery(String sql) - { - try { - Class.forName("net.sourceforge.jtds.jdbc.Driver"); - } - catch (ClassNotFoundException e) { - e.printStackTrace(); - } - try (Connection connection = DriverManager.getConnection(getJdbcUrl(), getUsername(), getPassword()); - Statement statement = connection.createStatement()) { - return connection.getMetaData().getColumns("testdb", null, "Persons2", null); -// return statement.executeQuery(sql); - } - catch (SQLException e) { - throw new RuntimeException(e); - } - } } From 49ebdb0c19ea9c4ea5912eb4f3906cc1f84b0ab5 Mon Sep 17 00:00:00 2001 From: academy-codex Date: Sat, 17 Jul 2021 12:48:05 +0530 Subject: [PATCH 2/2] removed unneeded comment; --- .../src/main/java/io/trino/plugin/sybase/SybaseClient.java | 1 - 1 file changed, 1 deletion(-) diff --git a/plugin/trino-sybase/src/main/java/io/trino/plugin/sybase/SybaseClient.java b/plugin/trino-sybase/src/main/java/io/trino/plugin/sybase/SybaseClient.java index 863a237c4a0d..5313d11dd316 100644 --- a/plugin/trino-sybase/src/main/java/io/trino/plugin/sybase/SybaseClient.java +++ b/plugin/trino-sybase/src/main/java/io/trino/plugin/sybase/SybaseClient.java @@ -56,7 +56,6 @@ public class SybaseClient extends BaseJdbcClient { - // SqlServer supports 2100 parameters in prepared statement, let's create a space for about 4 big IN predicates public static final int SYBASE_MAX_LIST_EXPRESSIONS = 500; private static final Joiner DOT_JOINER = Joiner.on(".");