Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Move exception handling to event system #1

Closed
nathaniel-may opened this issue Dec 7, 2023 · 2 comments
Closed

[Epic] Move exception handling to event system #1

nathaniel-may opened this issue Dec 7, 2023 · 2 comments

Comments

@nathaniel-may
Copy link

Problem:

  1. The way exceptions are raised often the only way to distinguish them when catching is to match on the string message. Updating wording of exceptions is a frequent community-driven improvement but has high risk of changing our exception handling anywhere in the system.
  2. User-facing string formatting is decentralized and often would require painstaking string parsing to extract important values if downstream code wanted to render the exception differently. Here is an example of this problem with ansi characters: (Issue) (Originating Exception)
  3. Catching exceptions from warehouse drivers often uses the string matching strategy as well. This leaves our exception handling strategy dependent on warehouse language settings being set to English. Exceptions are not properly handled for other languages. Example for Japanese.

Goals:

  • near zero risk of modifying exception messages
  • catching errors works across all warehouse language settings

Possible Solution:

  • leverage the event subsystem for exceptions as well

Relevant chain of tickets for dbt-core

Copy link

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 22, 2024
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant