Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-877] [Bug] Updating agate_helper in core requires update in of data type in some tests #915

Closed
2 tasks done
McKnight-42 opened this issue Sep 7, 2023 · 0 comments · Fixed by #916
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@McKnight-42
Copy link
Contributor

Is this a new bug in dbt-bigquery?

  • I believe this is a new bug in dbt-bigquery
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

the core merger of dbt-labs/dbt-core#8561 causes failing tests in docs_generate due to adding an integer to the definition which requires us to swap from float to int for expected values.

Expected Behavior

updating the expected type allows tests to pass again.

Steps To Reproduce

update local branch to main and run functional tests to see failures corresponding to error around stat field not meeting expected type.the

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-bigquery:

Additional Context

No response

@McKnight-42 McKnight-42 added bug Something isn't working triage labels Sep 7, 2023
@McKnight-42 McKnight-42 self-assigned this Sep 7, 2023
@McKnight-42 McKnight-42 removed the triage label Sep 7, 2023
@github-actions github-actions bot changed the title [Bug] Updating agate_helper in core requires update in of data type in some tests [ADAP-877] [Bug] Updating agate_helper in core requires update in of data type in some tests Sep 7, 2023
@McKnight-42 McKnight-42 mentioned this issue Sep 7, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant