Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3451] Move application logic in common.utils.jinja to common.clients.jinja #80

Closed
1 task done
Tracked by #8917
MichelleArk opened this issue Dec 5, 2023 · 2 comments
Closed
1 task done
Tracked by #8917
Labels

Comments

@MichelleArk
Copy link
Collaborator

MichelleArk commented Dec 5, 2023

Housekeeping

  • I am a maintainer of dbt-core

Short description

As part of the adapters decoupling work, much of dbt/clients/jinja and dbt/utils/jinja have moved to dbt/common. As highlighted by @colin-rogers-dbt in dbt-labs/dbt-core#9149 (comment), it'd be worth determining whether certain 'utils' are defining application logic and should themselves move to dbt.common.clients.jinja

Acceptance criteria

A spike report that highlights any potential approaches and their tradeoffs, as well as a summary of any potential blockers encountered.

Impact to Other Teams

N/A - should be a refactor.

Will backports be required?

nope

Context

dbt-labs/dbt-core#9149

@github-actions github-actions bot changed the title Move application logic in common.utils.jinja to common.clients.jinja [CT-3451] Move application logic in common.utils.jinja to common.clients.jinja Dec 5, 2023
@MichelleArk MichelleArk mentioned this issue Jan 10, 2024
5 tasks
@martynydbt martynydbt transferred this issue from dbt-labs/dbt-core Feb 14, 2024
Copy link

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 13, 2024
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant