Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Micorbatch] Ensure log lines related to microbatch batches have Batch prepended to them #11104

Closed
1 task done
QMalcolm opened this issue Dec 7, 2024 · 3 comments · Fixed by #11072
Closed
1 task done
Assignees
Labels
user docs [docs.getdbt.com] Needs better documentation

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Dec 7, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

Right now logs about batches look something like the following
Screenshot 2024-12-06 at 16 53 26 (2)

Notice how lines about batches X of 4 have the same format as lines about nodes X of 3. This is confusing because there easy way to visually parse what is going on.

Acceptance criteria

Make batch log lines distinct to be more easily visually parsable

Suggested Tests

N/A

Impact to Other Teams

N/A

Will backports be required?

Backport to 1.9.latest

Context

No response

@QMalcolm QMalcolm added the user docs [docs.getdbt.com] Needs better documentation label Dec 7, 2024
@QMalcolm QMalcolm self-assigned this Dec 7, 2024
@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#6613

@mirnawong1
Copy link
Contributor

mirnawong1 commented Dec 9, 2024

hey @QMalcolm , thanks for openign the docs issue up for this. does this need documentation or is this a ux/ui improvement?

i've tested it (i think correctly) and this is how the logs appeared to me when i ran dbt run. i added microbatch to the orders.sql model:

16:48:25 12 of 13 START sql microbatch model dbt_mwong.orders ........................... [RUN]
16:48:25 1 of 2 START batch 2024-12-08 of dbt_mwong.orders .............................. [RUN]
16:48:34 1 of 2 OK created batch 2024-12-08 of dbt_mwong.orders ......................... [�[32mSUCCESS 1947611�[0m in 9.00s]
16:48:34 2 of 2 START batch 2024-12-09 of dbt_mwong.orders .............................. [RUN]
16:48:43 2 of 2 OK created batch 2024-12-09 of dbt_mwong.orders ......................... [�[32mSUCCESS 1947611�[0m in 9.46s]
16:48:43 12 of 13 OK created sql microbatch model dbt_mwong.orders ...................... [�[32mSUCCESS�[0m in 18.47s]

@mirnawong1
Copy link
Contributor

Screenshot 2024-12-09 at 16 53 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants