Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate table statistics formatting in docs generation #1449

Closed
drewbanin opened this issue May 9, 2019 · 1 comment
Closed

Coordinate table statistics formatting in docs generation #1449

drewbanin opened this issue May 9, 2019 · 1 comment
Labels
artifacts dbt-docs [dbt feature] documentation site, powered by metadata artifacts stale Issues that have gone stale

Comments

@drewbanin
Copy link
Contributor

Code cleanup: currently, the docs site needs to hard-code the formatting specification for table stats provided in the catalog. Instead, dbt should denote how to format each "stats" column is specifies in the catalog (or, some sort of mapping separate from any individual catalog record).

As it stands, there's some unpleasant code that formats numbers appropriate in dbt docs:

var format = {
                    rows: asNumber, // Redshift
                    row_count: asNumber, // Snowflake
                    num_rows: asNumber, // BigQuery
                    max_varchar: asNumber,
                    pct_used: asPercent,
                    size: asBytes, // Redshift
                    bytes: asBytes, // Snowflake
                    num_bytes: asBytes, // BigQuery
                }

Who will this benefit?

Me, Drew Banin

@drewbanin drewbanin added the dbt-docs [dbt feature] documentation site, powered by metadata artifacts label May 9, 2019
@drewbanin drewbanin added this to the Louisa May Alcott milestone Aug 27, 2019
@cmcarthur cmcarthur removed this from the Louisa May Alcott milestone Sep 25, 2019
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifacts dbt-docs [dbt feature] documentation site, powered by metadata artifacts stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

3 participants