-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make default test-paths and analysis-paths configs consistent #2659
Comments
How do we feel about the config for models being named 'source-paths'? That's a bit confusing too since we have "models" and "sources" and "models" go in the "source-paths"... |
I'm wondering whether checking a directory for SQL files is the way we want to go in a world in which file contents are not acquired by looking at a filesystem. The "frontend" processor has to know which files to send and therefore would need to do those kinds of checks. So there's a bit of a chicken-and-egg problem (something we'll have to deal with in a storage adapter world anyway). |
@gshank You're absolutely right! See #1607, which is also on the v1.0 list. If you want to talk about that one at the same time as this issue, or consolidate the two into one effort, I think that would make a lot of sense.
This feels like a valuable discussion! We've talked in the past about using Jinja blocks to demarcate what code represents what thing, e.g. #184. That was prominently featured on our v1.0 list, way back when. It's not something I'm convinced we need or want to do, but I think it raises fair questions for a world where dbt doesn't have to be so tightly coupled with a file system. |
@leahwicz Yes, that sounds exactly right to me! Because the |
Describe the bug
Currently, the default values for various
<resource>-paths
are:(source)
The defaults for
test-paths
andanalysis-paths
:['test']
instead of['tests']
, and[]
instead of['analyses']
)dbt init
which are['tests']
and['analysis']
respectively (source),dbt init
test-paths
['tests']
['test']
['tests']
analysis-paths
['analyses']
[]
['analysis']
(singular)We should:
['tests']
and['analyses']
- Create a compatibility shim of some sort:- Jake: "in the default case, we can check if any *.sql files exist inside tests, and if not fall back to looking in test (and emit a deprecation warning). This will be annoying for a hopefully tiny subset of the population who have a directory named tests with sql files in it."We don't want to do this['analyses']
for new projects going forwardThe text was updated successfully, but these errors were encountered: