Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PP] Detect changes to selectors.yml #3873

Closed
jtcohen6 opened this issue Sep 13, 2021 · 2 comments
Closed

[PP] Detect changes to selectors.yml #3873

jtcohen6 opened this issue Sep 13, 2021 · 2 comments
Labels
bug Something isn't working partial_parsing stale Issues that have gone stale

Comments

@jtcohen6
Copy link
Contributor

Describe the bug

If I change selectors.yml and no other files, I still see:

Partial parsing enabled: 0 files deleted, 0 files added, 0 files changed.
Partial parsing enabled, no changes found, skipping parsing

This doesn't cause any big functional problems, such as selecting the wrong resources, because (I believe) selectors are re-parsed/rendered at runtime whenever a --selector flag is passed. It does matter, however, for saving the dict representation of selectors in manifest.json, which happens at parse time. That's increasingly important in a world where we support default selectors (#3448). It's quite confusing to update a yaml selector definition, dbt run --selector my_selector, see that it works, then check the manifest and see an outdated definition.

@jtcohen6 jtcohen6 added bug Something isn't working partial_parsing labels Sep 13, 2021
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label May 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working partial_parsing stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

1 participant