Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-411] [Feature] Seed json files #4936

Closed
1 task done
JCZuurmond opened this issue Mar 23, 2022 · 2 comments
Closed
1 task done

[CT-411] [Feature] Seed json files #4936

JCZuurmond opened this issue Mar 23, 2022 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request seeds Issues related to dbt's seed functionality

Comments

@JCZuurmond
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Let dbt seed also insert json files.

Describe alternatives you've considered

Upload json file outside of dbt

Who will this benefit?

Are you interested in contributing this feature?

Always - if I find the time

Anything else?

What is the idea behind supporting csv files? What is the motivation to (not) add new file types?

@JCZuurmond JCZuurmond added enhancement New feature or request triage labels Mar 23, 2022
@github-actions github-actions bot changed the title [Feature] Seed json files [CT-411] [Feature] Seed json files Mar 23, 2022
@jtcohen6
Copy link
Contributor

Thanks @JCZuurmond! Quick hits:

  • For seeds: I think this may be a dupe of Support newline-delimited JSON for seeds #2365, which has continued to garner interest. There are some pointers in Support newline-delimited JSON for seeds #2365 (comment) about what an implementation might look like. I'm going to tag in someone from the Execution team to take a look, for broader awareness of the request.
  • For uploading artifact files to the warehouse: We've had issues opened on specific adapters to support an (internal and intentionally undocumented) upload_file macro, the implementation of which will necessarily vary by adapter. IMO important to call out that the intended use case here is loading rich dbt metadata into the warehouse; we see this as an interim "hack" to offer in-dbt parity with other orchestration tools, especially for dbt Cloud users who lack other means of syncing JSON artifacts into the warehouse.

@jtcohen6 jtcohen6 added seeds Issues related to dbt's seed functionality Team:Execution labels Mar 23, 2022
@JCZuurmond
Copy link
Contributor Author

Thanks @jtcohen6 . Closing this issue due to duplication with #2365

@jtcohen6 jtcohen6 added duplicate This issue or pull request already exists and removed triage labels Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request seeds Issues related to dbt's seed functionality
Projects
None yet
Development

No branches or pull requests

2 participants