Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1916] Rename 'constraints_enabled' to 'contract' #6748

Closed
Tracked by #6747
MichelleArk opened this issue Jan 26, 2023 · 2 comments · Fixed by #7002
Closed
Tracked by #6747

[CT-1916] Rename 'constraints_enabled' to 'contract' #6748

MichelleArk opened this issue Jan 26, 2023 · 2 comments · Fixed by #7002
Assignees
Labels
multi_project user docs [docs.getdbt.com] Needs better documentation

Comments

@MichelleArk
Copy link
Contributor

In the foundational dbt Constraints work, we added a boolean config named constraints_enabled that “turns on” contracting for this model. Given that the scope of model contracts is broader than “constraints,” and that dbt’s enforcement may go beyond the built-in behavior of analytical data platforms, we should rename this config to contracted instead.

@github-actions github-actions bot changed the title Rename 'constraints_enabled' to 'contracted' [CT-1916] Rename 'constraints_enabled' to 'contracted' Jan 26, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Feb 1, 2023

@sungchun12 in #6271 (comment):

I recommend the syntax be: contract: true | false because contracted invokes imagery of pregnancy(a beautiful human experience but dissonant related to data contracts) at first glance and is in past tense, which may confuse the reader. Whenever the term data contracts come up, it's a noun in plural or singular, not a verb.

@gshank in live conversation:

When "the economy has contracted," that's not a good thing! I like contracts better.

@MichelleArk MichelleArk changed the title [CT-1916] Rename 'constraints_enabled' to 'contracted' [CT-1916] Rename 'constraints_enabled' to 'contracts' Feb 6, 2023
@jtcohen6
Copy link
Contributor

I'd vote for contract (singular) over contracts (false), given some of the recent discussion in #6726 about how this is a "producer-side" contract, and there's going to be exactly one (or zero) per model.

@jtcohen6 jtcohen6 changed the title [CT-1916] Rename 'constraints_enabled' to 'contracts' [CT-1916] Rename 'constraints_enabled' to 'contract' Feb 14, 2023
@gshank gshank self-assigned this Feb 17, 2023
@MichelleArk MichelleArk added the user docs [docs.getdbt.com] Needs better documentation label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi_project user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants