Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] [CT-2651] Add SemanticModels and Metrics to the DAG #7800

Closed
Tracked by #7498
QMalcolm opened this issue Jun 6, 2023 · 2 comments · Fixed by #7917
Closed
Tracked by #7498

[SPIKE] [CT-2651] Add SemanticModels and Metrics to the DAG #7800

QMalcolm opened this issue Jun 6, 2023 · 2 comments · Fixed by #7917
Assignees

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Jun 6, 2023

We've added SemanticModel and Metric nodes to the manifest, but we haven't added them to the dag. We need to get them added to the dag so that visualizations based on the DAG include SemanticModels and Metrics.

Note that inclusion of the SemanticModel node in the dag should include tested support for partial parsing. After initial implementation, changes to the semantic_model section of schema files is not triggering partial (or any) re-parse, as it should.

@github-actions github-actions bot changed the title Add SemanticModels and Metrics to the DAG [CT-2651] Add SemanticModels and Metrics to the DAG Jun 6, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 6, 2023

@QMalcolm Are you thinking about the visualization in dbt-docs? There & elsewhere, the main requirement from within dbt-core is that these resource types are included in manifest.json and the output of dbt list, with requisite information in their depends_on.nodes.

Edit: We also want to make sure that metrics and semantic_models appear in the flat_graphgraph context variable

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 9, 2023

Should metrics and semantic_models land in the same top-level key (semantic_nodes) of the manifest + graph context var? I think maybe!

@emmyoop emmyoop added the Refinement Maintainer input needed label Jun 12, 2023
@emmyoop emmyoop changed the title [CT-2651] Add SemanticModels and Metrics to the DAG [SPIKE] [CT-2651] Add SemanticModels and Metrics to the DAG Jun 12, 2023
@emmyoop emmyoop added the spike label Jun 12, 2023
@peterallenwebb peterallenwebb self-assigned this Jun 12, 2023
@peterallenwebb peterallenwebb removed the Refinement Maintainer input needed label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants