Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2666] Review Test Coverage of SemanticModels #7820

Closed
Tracked by #7498
peterallenwebb opened this issue Jun 7, 2023 · 3 comments
Closed
Tracked by #7498

[CT-2666] Review Test Coverage of SemanticModels #7820

peterallenwebb opened this issue Jun 7, 2023 · 3 comments
Assignees
Labels
semantic Issues related to the semantic layer

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Jun 7, 2023

During initial implementation of SemanticModels, we were moving quickly and did not add as much testing as is needed to fully verify functionality and prevent regressions. Let's use this issue to do that.

@peterallenwebb peterallenwebb added enhancement New feature or request triage labels Jun 7, 2023
@github-actions github-actions bot changed the title Improve Test Coverage of SemanticModels [CT-2666] Improve Test Coverage of SemanticModels Jun 7, 2023
@peterallenwebb peterallenwebb added MetricFlow and removed enhancement New feature or request triage labels Jun 7, 2023
@jtcohen6 jtcohen6 changed the title [CT-2666] Improve Test Coverage of SemanticModels [CT-2666] Review Test Coverage of SemanticModels Jul 5, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 5, 2023

This issue can be closed when:

  • reviewed the set of capabilities (and tests) we've added since initial implementation
  • created tickets for test cases that are still missing
  • added to current sprint for execution, or put into backlog if lower-priority

@QMalcolm QMalcolm added semantic Issues related to the semantic layer and removed MetricFlow labels Jul 18, 2023
@QMalcolm
Copy link
Contributor

QMalcolm commented Jul 18, 2023

Semantic Model tests are a fair bit more sparse than Metric tests. We currently have 4 tests in tests/functional/semantic_models/. There are 2 additional which assert anything about semantic_models outside of tests/functional/semantic_models. Additionally, more testing needs to be done on the sub protocols of semantic models in test_semantic_layer_nodes_satisfy_protocols.py.

  • Test SemanticModel.depends_on is properly populated
  • Test partial parsing in regards to SemanticModels (we have a test_pp_semantic_models.py but it's empty)
  • Additional protocol satisfication tests
    • SemanticModelDefaults
    • NodeRelation
    • MeasureAggregationParameters
    • DimensionTypeParams
    • DimensionValidityParams
  • Add tests to test_contract_graph_parsed.py specifically for semantic models

@QMalcolm
Copy link
Contributor

Added #8139, #8140, #8141, and #8142. They are being tracked as part of the Semantic Layer 1.7 Epic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semantic Issues related to the semantic layer
Projects
None yet
Development

No branches or pull requests

3 participants