Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2751] Support Configuration and Enabling/Disabling Semantic Models #7968

Closed
Tracked by #8125
peterallenwebb opened this issue Jun 27, 2023 · 2 comments · Fixed by #8502
Closed
Tracked by #8125

[CT-2751] Support Configuration and Enabling/Disabling Semantic Models #7968

peterallenwebb opened this issue Jun 27, 2023 · 2 comments · Fixed by #8502
Assignees
Labels
semantic Issues related to the semantic layer user docs [docs.getdbt.com] Needs better documentation

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Jun 27, 2023

Acceptance Criteria

  • A semantic_model can be enabled and disabled by YAML configuration, both individually and at the project level.
  • A semantic_model can be configured to belong to a group, both individually and at the project level, so that it can ref a private model within the same group.
# models/semantic.yml
```yml
semantic_models:
  - name: orders
    config:
      enabled: true | false
      group: some_group
# dbt_project.yml
semantic_models:
  my_project_name:
    +enabled: true | false
    +group: some_group
@github-actions github-actions bot changed the title Add Semantic Models to Project Class [CT-2751] Add Semantic Models to Project Class Jun 27, 2023
@peterallenwebb peterallenwebb self-assigned this Jun 27, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 10, 2023

@peterallenwebb I missed this one a few weeks ago! What are the implications of inclusion in the Project class? Is this something we need to get in before cutting the v1.6 RC on Thursday?

Update: Needed to support configuring semantic models, including enabled: true|false. Peter will update title + issue description with definition of done

@peterallenwebb peterallenwebb changed the title [CT-2751] Add Semantic Models to Project Class [CT-2751] Support Configuration and Enabling/Disabling Semantic Models Jul 10, 2023
@QMalcolm QMalcolm added semantic Issues related to the semantic layer and removed MetricFlow labels Jul 18, 2023
@jtcohen6 jtcohen6 added the enhancement New feature or request label Aug 15, 2023
@jtcohen6
Copy link
Contributor

@emmyoop I updated the description, to reflect some findings from my own local testing:

  • currently semantic_models do not accept a config property at all in their yaml definitions
  • we'd also want to support group as a config, in addition to enabled, so that semantic models could reference a private model defined within the same group

@emmyoop emmyoop removed the enhancement New feature or request label Aug 31, 2023
@graciegoheen graciegoheen added the user docs [docs.getdbt.com] Needs better documentation label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semantic Issues related to the semantic layer user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants