Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2951] [Feature] All nodes should be groupable #8343

Closed
3 tasks done
gwenwindflower opened this issue Aug 8, 2023 · 3 comments
Closed
3 tasks done

[CT-2951] [Feature] All nodes should be groupable #8343

gwenwindflower opened this issue Aug 8, 2023 · 3 comments
Labels
enhancement New feature or request model_groups_access Issues related to groups

Comments

@gwenwindflower
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Community members brought up that it would be useful to group sources, while it's true this isn't really necessary for common patterns in a multi-project setting, in a monorepo it's actually a really useful safeguard to prevent something like this:

Monorepo, 2 teams
Platform group: owns staging models and handles landing data
Transformation group: can access staging models and builds marts

Transformation team could still source() something and totally bypass protections. I think it's reasonable to expect that you can control access to any node with groups.

Describe alternatives you've considered

Again, in a multi-project setting where you have more separation I don't think this is critical, but a lot of people are going to sort out how they mesh stuff using groups first for some period of time if not perpetually.

Who will this benefit?

People using groups/access/governance in a monorepo.

Are you interested in contributing this feature?

Unfortunately no capacity for this right now.

Anything else?

I love you all. ❤️

@gwenwindflower gwenwindflower added enhancement New feature or request triage labels Aug 8, 2023
@github-actions github-actions bot changed the title [Feature] All nodes should be groupable [CT-2951] [Feature] All nodes should be groupable Aug 8, 2023
@gwenwindflower
Copy link
Author

via this Community Slack discussion https://getdbt.slack.com/archives/C2JRRQDTL/p1691497125957839

@jtcohen6
Copy link
Contributor

jtcohen6 commented Aug 9, 2023

@gwenwindflower Thanks for opening! There's been some related conversation in this issue: #7750

What do you think of consolidating the two conversations? The only node types that are intentionally ungroupable today are sources and exposures, and the focus of this issue seems to be sources as well.

@jtcohen6 jtcohen6 added model_groups_access Issues related to groups and removed triage labels Aug 9, 2023
@gwenwindflower
Copy link
Author

closing to collapse into #7750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request model_groups_access Issues related to groups
Projects
None yet
Development

No branches or pull requests

2 participants