-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-3102] [Bug] semantic models don't support partial parsing #8609
Comments
Thanks for reporting this @dave-connors-3 ! @Jstein77 or @QMalcolm -- is there any reason why we wouldn't want to match the expected behavior that @dave-connors-3 described? |
I was under the impression that this method is used for @dave-connors-3 Any chance you could include your full reproduction case? (yaml you started with, commands you ran, yaml you changed it to) |
@dave-connors-3 looking forward to seeing you at the San Diego edition of Coalesce! Would you be willing to walk me though a more detailed reproduction case? We discovered a couple other issues related to partial parsing (#8859 and #8860), and it would good to tackle the issue you are reporting at the same time. What we're going for a is a step-by-step set of instructions and engineer could use to both trigger the problem and then confirm it's fixed afterwards (like this). I'm willing to write it up if you can walk me through it in-person. |
@dave-connors-3 thanks for jamming on this with me in San Diego! 🏖️ Based on what we looked at together, we agreed that the (lack of changes) you saw within Thanks again -- you rock 🎸 |
Is this a new bug in dbt-core?
Current Behavior
Semantic models don't appear to support partial parsing -- in working through #8589, once semantic models were added to the
dbt ls
command output, tests were failing related to partial parsing. It turns out that theSemanticModel
class does not contain any comparison methods to detect changes (namelysame_contents
) that allow for partial parsingExpected Behavior
SMs are parsed with consistent behavior to other node types
Steps To Reproduce
Relevant log output
No response
Environment
Which database adapter are you using with dbt?
postgres
Additional Context
No response
The text was updated successfully, but these errors were encountered: