Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3102] [Bug] semantic models don't support partial parsing #8609

Closed
2 tasks done
Tracked by #8125
dave-connors-3 opened this issue Sep 11, 2023 · 4 comments
Closed
2 tasks done
Tracked by #8125

[CT-3102] [Bug] semantic models don't support partial parsing #8609

dave-connors-3 opened this issue Sep 11, 2023 · 4 comments
Labels
bug Something isn't working partial_parsing

Comments

@dave-connors-3
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Semantic models don't appear to support partial parsing -- in working through #8589, once semantic models were added to the dbt ls command output, tests were failing related to partial parsing. It turns out that the SemanticModel class does not contain any comparison methods to detect changes (namely same_contents) that allow for partial parsing

Expected Behavior

SMs are parsed with consistent behavior to other node types

Steps To Reproduce

  1. create SM
  2. update it
  3. run dbt compile
  4. notice no changes

Relevant log output

No response

Environment

- OS: TJ mac
- Python: 3.10
- dbt: 1.7.0b2

Which database adapter are you using with dbt?

postgres

Additional Context

No response

@dave-connors-3 dave-connors-3 added bug Something isn't working triage labels Sep 11, 2023
@dave-connors-3 dave-connors-3 self-assigned this Sep 11, 2023
@dave-connors-3 dave-connors-3 changed the title [Bug] semantic models don't support partial parsin [Bug] semantic models don't support partial parsing Sep 11, 2023
@github-actions github-actions bot changed the title [Bug] semantic models don't support partial parsing [CT-3102] [Bug] semantic models don't support partial parsin Sep 11, 2023
@dave-connors-3 dave-connors-3 changed the title [CT-3102] [Bug] semantic models don't support partial parsin [CT-3102] [Bug] semantic models don't support partial parsinf Sep 11, 2023
@dave-connors-3 dave-connors-3 changed the title [CT-3102] [Bug] semantic models don't support partial parsinf [CT-3102] [Bug] semantic models don't support partial parsing Sep 11, 2023
@dbeatty10
Copy link
Contributor

Thanks for reporting this @dave-connors-3 !

@Jstein77 or @QMalcolm -- is there any reason why we wouldn't want to match the expected behavior that @dave-connors-3 described?

@jtcohen6
Copy link
Contributor

(namely same_contents) that allow for partial parsing

I was under the impression that this method is used for state:modified comparisons (Slim CI), but not for partial parsing. There may be something else afoot!

@dave-connors-3 Any chance you could include your full reproduction case? (yaml you started with, commands you ran, yaml you changed it to)

@dbeatty10
Copy link
Contributor

@dave-connors-3 looking forward to seeing you at the San Diego edition of Coalesce!

Would you be willing to walk me though a more detailed reproduction case? We discovered a couple other issues related to partial parsing (#8859 and #8860), and it would good to tackle the issue you are reporting at the same time.

What we're going for a is a step-by-step set of instructions and engineer could use to both trigger the problem and then confirm it's fixed afterwards (like this).

I'm willing to write it up if you can walk me through it in-person.

@dbeatty10
Copy link
Contributor

@dave-connors-3 thanks for jamming on this with me in San Diego! 🏖️

Based on what we looked at together, we agreed that the (lack of changes) you saw within manifest.json is likely covered by #8859, so I'm going to close this in favor of that issue.

Thanks again -- you rock 🎸

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2023
@dbeatty10 dbeatty10 removed the triage label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working partial_parsing
Projects
None yet
Development

No branches or pull requests

3 participants