Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Change GenericExceptionOnRun to have node_info #9557

Closed
2 tasks done
Tracked by #8283
dbeatty10 opened this issue Feb 12, 2024 · 0 comments · Fixed by #9559
Closed
2 tasks done
Tracked by #8283

[Bug] Change GenericExceptionOnRun to have node_info #9557

dbeatty10 opened this issue Feb 12, 2024 · 0 comments · Fixed by #9559
Assignees
Labels
backport 1.7.latest bug Something isn't working pre-release Bug not yet in a stable release unit tests Issues related to built-in dbt unit testing functionality
Milestone

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Feb 12, 2024

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

If a "generic" error occurs in a call runner (such as a Python keyword error), the "GenericExceptionOnRun" logging event is issued, but doesn't have node_info in it. All call runners have a node associated with them, so we should add node_info to events that are issued in the call runner code path.

Expected Behavior

The GenericExceptionOnRun logging event should have node_info.

Steps To Reproduce

Generally in order to see this, you would have to have a Python error. This happened for a pre-release version of the unit testing feature, but is hard to reproduce in a test case since you'd have to force a Python error.

Relevant log output

The lack of GenericExceptionOnRun in the node associated logs in the IDE.

Environment

- OS:
- Python:
- dbt:

Additional Context

Internal slack thread: https://dbt-labs.slack.com/archives/C012TTNN0JK/p1707407183148229

@gshank said that the solution might be:

for this particular case we could change GenericExceptionOnRun to have node_info since it's thrown in a call runner

@dbeatty10 dbeatty10 added bug Something isn't working triage labels Feb 12, 2024
@graciegoheen graciegoheen added the pre-release Bug not yet in a stable release label Feb 12, 2024
@dbeatty10 dbeatty10 removed the triage label Feb 12, 2024
@martynydbt martynydbt added this to the v1.8 milestone Feb 12, 2024
@dbeatty10 dbeatty10 added the unit tests Issues related to built-in dbt unit testing functionality label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest bug Something isn't working pre-release Bug not yet in a stable release unit tests Issues related to built-in dbt unit testing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants