Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove manifest from adapter.get_catalog signature #9212

Closed

Fix type annotations for python 3.8

0745c89
Select commit
Loading
Failed to load commit list.
Closed

remove manifest from adapter.get_catalog signature #9212

Fix type annotations for python 3.8
0745c89
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 5, 2023 in 1s

73.68% of diff hit (within 80.00% threshold of 86.56%)

View this Pull Request on Codecov

73.68% of diff hit (within 80.00% threshold of 86.56%)

Annotations

Check warning on line 474 in core/dbt/adapters/base/impl.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/dbt/adapters/base/impl.py#L474

Added line #L474 was not covered by tests

Check warning on line 1184 in core/dbt/adapters/base/impl.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/dbt/adapters/base/impl.py#L1184

Added line #L1184 was not covered by tests

Check warning on line 265 in core/dbt/task/docs/generate.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/dbt/task/docs/generate.py#L265

Added line #L265 was not covered by tests

Check warning on line 273 in core/dbt/task/docs/generate.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/dbt/task/docs/generate.py#L272-L273

Added lines #L272 - L273 were not covered by tests