Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tree view if null database (spark) #104

Closed
jtcohen6 opened this issue Jun 22, 2020 · 2 comments
Closed

Adjust tree view if null database (spark) #104

jtcohen6 opened this issue Jun 22, 2020 · 2 comments
Labels
enhancement New feature or request good_first_issue Good for newcomers Stale

Comments

@jtcohen6
Copy link
Contributor

On Spark, where database is always null, the Database tree view looks like:

Screen Shot 2020-06-22 at 10 41 57 AM

Suggestions from @dallyhorton, who initially surfaced this in Slack:

I would suggest just using the name of the project in place of the null. Better still, do we need a root node? It just mean one less click to expand the list of schemas. If we need the root node, could we default the tree to expanded (instead of collapsed)?

@jtcohen6 jtcohen6 added enhancement New feature or request good_first_issue Good for newcomers labels Jun 22, 2020
@markdessain
Copy link

Had the same issue and was pointed in this direction. Not had time to look at the underlying code but a quick fix / workaround is to run the following after generating the documentation:

sed 's/"database": null/"database": "<DATABASE_NAME>"/g' ./target/manifest.json

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Good for newcomers Stale
Projects
None yet
Development

No branches or pull requests

2 participants