Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile during release #3

Closed
jtcohen6 opened this issue Dec 1, 2020 · 6 comments · Fixed by #12
Closed

Add dockerfile during release #3

jtcohen6 opened this issue Dec 1, 2020 · 6 comments · Fixed by #12
Assignees

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Dec 1, 2020

Currently, the dbt release flow:

  • adds a requirements file to the dbt repo here
  • uploads a new image to Docker Hub here

It does not:

  • add a new dockerfile here

This gives the appearance of our not maintaining docker files / images for each version of dbt, when that's not true. We should either:

  • add a dockerfile to the release commit
  • if that's not possible, consider removing dockerfiles from the dbt repo, and instead redirecting community members to use the images
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Jan 2, 2021

As possible, let's also backfill the missing dockerfiles for v0.17.0 through v0.19.0

@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Jan 6, 2021

Update: Per @kwigley's suggestion, we should just maintain the single simple Dockerfile in dbt, not tied to any one specific version. For clarity, we should remove the older versioned Dockerfiles.

We should continue to publish requirements.txt that are specific to each version.

@kwigley
Copy link

kwigley commented Jan 6, 2021

@jtcohen6 thanks for the bookkeeping 😄

@kwigley kwigley self-assigned this Jan 7, 2021
@edbizarro
Copy link

edbizarro commented Jan 16, 2021

are those USER_ID and GROUP_ID supported for the old tags like 0.18.1 ?

@kwigley
Copy link

kwigley commented Jan 20, 2021

Cleaned up docker resources in the dbt repo here dbt-labs/dbt-core#3019

Still need to update the dbt-release scripts to use dockerfile in the dbt repo for building and pushing a docker image for releases.

@kwigley
Copy link

kwigley commented Jan 20, 2021

are those USER_ID and GROUP_ID supported for the old tags like 0.18.1 ?

@edbizarro are you referring to the development docker image?
https://github.com/fishtown-analytics/dbt/blob/1f927a374c8bd52a12a20d892fed9d59cffd04f4/Dockerfile#L53-L57
If so, I believe the answer is yes.

The Dockerfile we use to publish dbt as a docker image to Docker Hub can be found here https://github.com/fishtown-analytics/dbt/pull/3019/files#diff-f34da55ca08f1a30591d8b0b3e885bcc678537b2a9a4aadea4f190806b374ddc.

Does this help with your question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants