Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Create relations as case-sensitive by default #1111

Open
3 tasks done
aranke opened this issue Jul 10, 2024 · 0 comments
Open
3 tasks done

[Feature] Create relations as case-sensitive by default #1111

aranke opened this issue Jul 10, 2024 · 0 comments
Labels
enhancement New feature or request user docs [docs.getdbt.com] Needs better documentation

Comments

@aranke
Copy link
Member

aranke commented Jul 10, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Follow-up issue from #1107 (comment).

Evaluate the impact of creating relation parts as case-sensitive by default:

  1. Upper-case if quoting is off
  2. Same-case if quoting is on

Describe alternatives you've considered

Use relation.as_case_sensitive() wherever required.

Who will this benefit?

dbt-snowflake maintainers

Are you interested in contributing this feature?

Sure

Anything else?

We should look at doing this "on the way in" instead of as it's used. We need to account for the fact that Snowflake makes it's relation identifiers uppercase if they are not quoted. This happens in a few cases. If we model this Snowflake behavior when the SnowflakeRelation is created, then we don't need to account for it later. This could impact other processes though, so we should be thorough about testing and be clear in the user docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

No branches or pull requests

3 participants