Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-1043] Handle errors more gracefully when Snowflake is configured to use languages other than English #843

Open
nathaniel-may opened this issue Nov 22, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@nathaniel-may
Copy link
Contributor

nathaniel-may commented Nov 22, 2023

New issue for problem raised in #834 with associated Community PR .

Snowflake allows users to set their language. When we string match to catch errors on the English wording this fails to catch errors when Snowflake is configured to use a language other than English.

  • What was the original reason the code uses string matching here?
  • Is there an alternative, language-agnostic way for us to identify errors? (python class types, error codes etc)

Definition of Done:
When a user configures Snowflake to use any language other than English, the error handling behavior remains the same.

@nathaniel-may nathaniel-may added enhancement New feature or request triage labels Nov 22, 2023
@github-actions github-actions bot changed the title Handle errors more gracefully when Snowflake is configured to use languages other than English [ADAP-1043] Handle errors more gracefully when Snowflake is configured to use languages other than English Nov 22, 2023
@nathaniel-may nathaniel-may removed triage enhancement New feature or request labels Nov 22, 2023
@dataders
Copy link
Contributor

this error message string handling was introduced in #107 and happens currently in two places

get_columns_in_relation

except DbtDatabaseError as exc:
if "does not exist or not authorized" in str(exc):
return []

list_relations_without_caching

if "Object does not exist" in str(exc):
return []

@mikealfare mikealfare added the enhancement New feature or request label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants