Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist_docs is not called in incremental models #224

Closed
binhnefits opened this issue Oct 7, 2021 · 2 comments
Closed

persist_docs is not called in incremental models #224

binhnefits opened this issue Oct 7, 2021 · 2 comments
Labels
bug Something isn't working good_first_issue Good for newcomers

Comments

@binhnefits
Copy link
Contributor

Describe the bug

persist_docs adds column comments to delta tables but its not called in incremental models

Steps To Reproduce

Expected behavior

Screenshots and log output

**The operating system you're using: Ubuntu

**The output of python --version: 3.7

Additional context

@binhnefits binhnefits added bug Something isn't working triage labels Oct 7, 2021
@jtcohen6
Copy link
Contributor

@binhnefits Thanks for opening!

As I said over in I think it would just look like adding

{% do persist_docs(target_relation, model) %}

to the end of the incremental materialization, right above run_hooks, just like in the table materialization:

{% do persist_docs(target_relation, model) %}
{{ run_hooks(post_hooks) }}

@jtcohen6
Copy link
Contributor

resolved by #234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good_first_issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants