Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-519] Remove unused # type: ignore #753

Closed
3 tasks done
Fokko opened this issue May 8, 2023 · 1 comment · Fixed by #754
Closed
3 tasks done

[ADAP-519] Remove unused # type: ignore #753

Fokko opened this issue May 8, 2023 · 1 comment · Fixed by #754
Labels
enhancement New feature or request

Comments

@Fokko
Copy link
Contributor

Fokko commented May 8, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-spark functionality, rather than a Big Idea better suited to a discussion

Describe the feature

I noticed that there are quite a few # type: ignore around. I enabled the --warn-unused-ignores flag and found out that some of them are not needed.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

Yes

Anything else?

Small one :)
@Fokko Fokko added enhancement New feature or request triage labels May 8, 2023
@github-actions github-actions bot changed the title Remove unused # type: ignore [ADAP-519] Remove unused # type: ignore May 8, 2023
@Fokko Fokko mentioned this issue May 8, 2023
Merged
6 tasks
@dbeatty10
Copy link
Contributor

Thank you @Fokko for noticing and opening a PR ❤️

@dbeatty10 dbeatty10 removed the triage label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused # type: ignore Fokko/dbt-spark
2 participants
@Fokko @dbeatty10