Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use adapter.quote() for get_table_types_sql #572

Closed
dbeatty10 opened this issue May 3, 2022 · 4 comments · Fixed by #636
Closed

Use adapter.quote() for get_table_types_sql #572

dbeatty10 opened this issue May 3, 2022 · 4 comments · Fixed by #636
Labels
enhancement New feature or request good first issue

Comments

@dbeatty10
Copy link
Contributor

Describe the feature

Use adapter.quote() instead of double-quotes or backticks within macros/sql/get_table_types_sql.sql (as described here
#537 (comment))

Who will this benefit?

This will make things cleaner and more simple when macros are migrated for dbt-labs/dbt-core#4813

@dbeatty10 dbeatty10 added enhancement New feature or request good first issue labels May 3, 2022
@alla-bongard
Copy link
Contributor

I am happy to pick this up!

@dbeatty10
Copy link
Contributor Author

Awesome @alla-bongard !

The update would go in the following places:

For good measure, these could be optionally updated also:

Note: If the bigquery__get_table_types_sql implementation becomes identical to the default__get_table_types_sql one, then it should be removed altogether 🙏

@alla-bongard
Copy link
Contributor

alla-bongard commented Aug 12, 2022

clear, and it was exactly what I did locally! a PR is on the way! :)

@dbeatty10
Copy link
Contributor Author

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants