postgres: Don't pin botocore version #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`snowflake-connector-python` doesn't pin it, and it restricts us to a much older version of boto3 than the boto3 pin would otherwise allow (specifically, botocore<1.15 requires boto3<1.12).
jtcohen6
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
@stpierre Thanks for the find on this one. You're right, snowflake-connector-python removed their tight range on botocore, which is great news.
Could you indeed add an "under the hood" changelog note to this effect, and add yourself to the list of contributors? There are a lot of folks who keep keen eyes on dependency updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the pin for
botocore, which isn't necessary.snowflake-connector-pythondoesn't pin it, and it restricts us to a much older version of boto3 than the boto3 pin would otherwise allow (specifically, botocore<1.15 requires boto3<1.12).Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.