Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deprecation: execute-macro-release #3900

Closed
emmyoop opened this issue Sep 16, 2021 · 0 comments · Fixed by #3907
Closed

Enable deprecation: execute-macro-release #3900

emmyoop opened this issue Sep 16, 2021 · 0 comments · Fixed by #3907
Assignees

Comments

@emmyoop
Copy link
Member

emmyoop commented Sep 16, 2021

Introduced in: v0.17.2
In the last week, raised by: 0 projects

Pretty straightforward: as the deprecation warning message states, we should remove the release arg from the execute_macro method. I don't think we need to worry too much about moving text_only_columns up one positional argument, but it may not be a bad idea to leave a placeholder in its spot.

https://github.com/dbt-labs/dbt/blob/484517416f3ec7affb22f3f1be4f19b2ef825332/core/dbt/adapters/base/impl.py#L961-L964

Then, we can remove it from the list of active deprecations.

Originally posted by @jtcohen6 in #2798 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant