-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setup_db.sh by waiting for pg_isready success return. Fixes #3876 #3908
Fix setup_db.sh by waiting for pg_isready success return. Fixes #3876 #3908
Conversation
forgive me while I close and reopen the PR to kick off the integration test workflow 🤦 , we are still working on a mechanism to re-trigger integration tests! |
d5d6a89
to
0f694aa
Compare
I rebased the branch with |
… contributing md files
…ker compose also creates it...
0f694aa
to
d0db8e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvacaru Thanks for the contribution! The change itself looks good to me. I'm going to move your changelog note up to the topmost section, then we can merge this in :)
resolves #3876
Description
The
setup_db.sh
script now waits for the postgres instance to be ready before terminating execution. Code for the creation ofdbt
database,root
roles and grants ondbt
has been removed since this is already done in the docker compose. The creation of rolenoaccess
and dbdbtMixedCase
is kept.Mind that I didn't successfully run
make integration
because I get an import error on all the tests ondbt.main
. What I tested is that after the script ends I'm able to connect to postgres with:psql postgresql://root:password@localhost:5432/dbtMixedCase
psql postgresql://root:password@localhost:5432/dbt
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.