[#3961] Enable cataloging of unlogged Postgres tables #3993
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @samlader |
|
I have now signed the CLA 🙂 |
samlader
changed the title
There was a problem hiding this comment.
@samlader Thanks for the contribution, and for adding a great integration test!
This change looks just about good to ship. Could you add yourself to the list of Contributors? I've also added the ok to test label, so the rest of the Postgres integration suite should run on your next commit.
| @@ -36,7 +36,7 @@ | |||
| {%- endfor -%} | |||
| ) | |||
| and not pg_is_other_temp_schema(sch.oid) -- not a temporary schema belonging to another session | |||
| and tbl.relpersistence = 'p' -- [p]ermanent table. Other values are [u]nlogged table, [t]emporary table | |||
| and tbl.relpersistence in ('p', 'u') -- [p]ermanent table or [u]nlogged table. Exclude [t]emporary tables | |||
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Description
Resolves #3961
This is my first contribution to dbt. I would appreciate guidance on any additional changes I can make to improve this PR. 🙂
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.