Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent cookie policy pop-up in Vercel preview #4757

Closed
1 task done
dbeatty10 opened this issue Jan 16, 2024 · 1 comment
Closed
1 task done

Persistent cookie policy pop-up in Vercel preview #4757

dbeatty10 opened this issue Jan 16, 2024 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists engineering improvement that requires site engineering help or back up

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Jan 16, 2024

Contributions

  • I have read the contribution docs, and understand what's expected of me.

What page(s) or areas on docs.getdbt.com are affected?

To the best I can tell, this affects all page(s) within the Vercel preview.

Example:

https://docs-getdbt-com-git-mwong-cross-db-macros-dbt-labs.vercel.app/reference/dbt-jinja-functions/cross-database-macros

Screenshot:

image

What changes are you suggesting?

It doesn't matter if I click "Reject All" or "Accept Cookies" -- I get the same pop-up the next time the page loads. And the rest of the page is greyed out and I can't navigate to other pages by clicking the links in the left-hand menu.

Additional information

I'm working around this by:

  1. First, searching for the page I want within the public web documentation on getdbt.com (rather than the Vercel preview in a PR).
  2. Second, going to the Vercel preview
  3. Copy the ending portion of the URL from step 1 and pasting it into the preview URL from step 2.

Update: @nghi-ly gave me the pro-tip of adding ?otreset=true&otpreview=true&otgeo=us,va to the end of the URL which helps.

It still continues to pop-up the cookie policy bit no matter what I choose, but adding that little bit actually lets me navigate the page 💪

@dbeatty10 dbeatty10 added bug Something isn't working engineering improvement that requires site engineering help or back up labels Jan 16, 2024
@nghi-ly
Copy link
Contributor

nghi-ly commented Jan 16, 2024

there's an asana ticket filed for this bug. John Rock, back in June, investigated this a bit and found that OneTrust is adding an event on the body of the page after accepting the cookies.

closing bc we have an asana ticket tracking this bug. feel free to reopen if we wanna track it here as well

@nghi-ly nghi-ly closed this as completed Jan 16, 2024
@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2024
@dbeatty10 dbeatty10 added the duplicate This issue or pull request already exists label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists engineering improvement that requires site engineering help or back up
Projects
None yet
Development

No branches or pull requests

2 participants