-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize ser/de for array of basic/fixed types #144
Comments
I agree but I've a feeling we don't need to special-case |
@elmarco Wasn't this fixed with !267? |
In GitLab by @elmarco on Mar 14, 2021, 18:46 There is room for improvements for arrays others than [u8] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In GitLab by @elmarco on Mar 1, 2021, 12:55
Our Vec implementation is pretty slow, due to the genericity of value handling.
For a rough idea, it takes about 5s to ser/de a 10mb vector of bytes (ay) on a pretty fast CPU.
Here is the flamegraph link: https://elmarco.fedorapeople.org/zbus_vec_flamegraph.svg
Imho, optimizing 'ay' is the most important, as there is a higher chance to transfer big data blobs in this form.
The text was updated successfully, but these errors were encountered: