Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ser/de for array of basic/fixed types #144

Closed
zeenix opened this issue Mar 1, 2021 · 5 comments
Closed

Optimize ser/de for array of basic/fixed types #144

zeenix opened this issue Mar 1, 2021 · 5 comments

Comments

@zeenix
Copy link
Contributor

zeenix commented Mar 1, 2021

In GitLab by @elmarco on Mar 1, 2021, 12:55

Our Vec implementation is pretty slow, due to the genericity of value handling.

For a rough idea, it takes about 5s to ser/de a 10mb vector of bytes (ay) on a pretty fast CPU.

Here is the flamegraph link: https://elmarco.fedorapeople.org/zbus_vec_flamegraph.svg

Imho, optimizing 'ay' is the most important, as there is a higher chance to transfer big data blobs in this form.

@zeenix
Copy link
Contributor Author

zeenix commented Mar 1, 2021

Imho, optimizing 'ay' is the most important, as there is a higher chance to transfer big data blobs in this form.

I agree but I've a feeling we don't need to special-case y here but implement a solution for arrays in general.

@zeenix
Copy link
Contributor Author

zeenix commented Mar 14, 2021

@elmarco Wasn't this fixed with !267?

@zeenix
Copy link
Contributor Author

zeenix commented Mar 14, 2021

In GitLab by @elmarco on Mar 14, 2021, 18:46

There is room for improvements for arrays others than [u8]

@zeenix
Copy link
Contributor Author

zeenix commented Sep 5, 2024

This is done with #966 that brought in up to 94% performance improvements for fixed-sized arrays. Most likely we'll see even more improvements with #882 fully addressed in 5.0.

@zeenix
Copy link
Contributor Author

zeenix commented Oct 5, 2024

This is done with #966 that brought in up to 94% performance improvements for fixed-sized arrays. Most likely we'll see even more improvements with #882 fully addressed in 5.0.

We're already in 5.0 times in main branch and #882 has been resolved.

@zeenix zeenix closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant