Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filterHandler still says default filter(null) #1224

Closed
gordonwoodhull opened this issue Nov 15, 2016 · 2 comments
Closed

filterHandler still says default filter(null) #1224

gordonwoodhull opened this issue Nov 15, 2016 · 2 comments
Labels
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

To resolve #989 / #960, we eliminated the inefficient and unnecessary initial dimension.filter(null) but the docs still say we do that, which will encourage inefficient customizations.

@gordonwoodhull
Copy link
Contributor Author

The supposed "default filter handler" also doesn't have any of the efficiency improvements of filterType - completely out of date.

@gordonwoodhull
Copy link
Contributor Author

It still seems pretty messy to quote all that code, especially with how complicated the default filter handler has become. But I don't have a better solution, so I'm just updating it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant