-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade lineChart.interpolate -> lineChart.curve in a backward-compatible way #1376
Comments
This is a good idea. It has some additional benefit. See below. I also wanted to change the behavior of I was thinking to set value of default tension to This also has one benefit that one can apply the tension to the d3 curve function before passing it to |
That's great. Maybe we should deprecate |
Great, will make these changes and raise a PR. |
fixed by #1381 |
Since d3 has replaced
d3.svg.line.interpolate
withd3.line.curve
, we should too. But we have the opportunity to do it in a mostly backward-compatible way.First, we can create the new
lineChart.curve()
which takes a curve object, but leavelineChart.interpolate()
, still taking a string but instantiating the right curve object based on the old names of interpolations. We should deprecateinterpolate
using dc.logger.deprecate, and remove it in 3.1 or later.@kum-deepak, I think we can leave
tension
the way you have implemented it in _interpolateWithTension, but instead of silently dropping tension when it's not applicable, we should warn the user in the browser console, "Tension specified for a curve that doesn't support it, ignored"The text was updated successfully, but these errors were encountered: