-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore brush animation and correct height on resize #1399
Comments
On to it :) |
Looks like I have to practice first some transition examples. As of now I am able to handle the resizing correctly, animate the brush handles. Unable to animate the brush selection rectangle (it is done by d3.brush, but the documentation says that transitions can be applied on that). |
Don't you just pass a transition to |
I must be making some simple error. There is a sample as well where they animate the brush selection: I will commit one version later in the day my time. |
Started work #1402. Based on your feedback, I will implement for other classes as well. |
fixed in 3.0 alpha 7 |
In this example you can resize the browser window to test chart resizing:
http://127.0.0.1:8888/web/resizing/resizing-bar.html
The brush used to transition at the same speed as the chart; now it changes immediately. (This was the purpose of the
doTransition
argument toredrawBrush
, used indrawChart
.)Also it seems to get the width right but height stays at the original height.
If you fix the
onresize
bug (thank you @kum-deepak!), this example works in 2.1: http://dc-js.github.io/dc.js/resizing/resizing-bar.htmlThe text was updated successfully, but these errors were encountered: