Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

horizontal brush is showing in scatter plot #1406

Closed
gordonwoodhull opened this issue Apr 14, 2018 · 5 comments
Closed

horizontal brush is showing in scatter plot #1406

gordonwoodhull opened this issue Apr 14, 2018 · 5 comments
Labels
bug
Milestone
3.0

Comments

@gordonwoodhull
Copy link
Contributor

screen shot 2018-04-14 at 12 49 57 pm

It looks like somehow we have two brushes in the scatter plot. The XY brush works fine, but the horizontal brush crashes if you try to drag it.

I haven't looked closely at the implementation to see why this is.
@gordonwoodhull gordonwoodhull added this to the 3.0 milestone Apr 14, 2018
@kum-deepak
Copy link
Collaborator

It was fixed in one of the later commits for #1402, I will open another PR with the remaining changes.

@kum-deepak kum-deepak mentioned this issue Apr 14, 2018
Merged
@kum-deepak
Copy link
Collaborator

Please check #1407

@gordonwoodhull
Copy link
Contributor Author

Oh phooey did I miss a commit? Thanks for the prompt fixup!

@kum-deepak
Copy link
Collaborator

No, not your issue, it was buried as part of refactoring. I have created a simple PR (just one line change) and also used this opportunity to add a test case, which fails without this commit.

@gordonwoodhull
Copy link
Contributor Author

fixed in 3.0 alpha 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@gordonwoodhull @kum-deepak