-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should crossfilter.quicksort be replaced by Array.sort #1559
Comments
Yes, in fact we recently had a discussion about this on the crossfilter repo. It shouldn't be using a hand-rolled sort either: crossfilter/crossfilter#1559 |
Let's do this in 3.1.x as well as 4.0. I can backport if you fix it in the es6 branch. |
I have created a pull request. The change should work without ES6 as well. |
fixed by #1560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems
crossfilter.quicksort
is the only function used by dc itself fromcrossfilter
. If this can be replaced byArray.sort
(or something similar),crossfilter
can become a dev dependency.The text was updated successfully, but these errors were encountered: