-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d3-collection dependency missing (es module usage) #1822
Comments
@kum-deepak can answer this better, but dc.js doesn't depend on d3-collection, which was removed from d3@6. This module is attempting to detect whether d3@5 or d3@6 is active and won't call Perhaps we need better support for users doing their own transpilation. |
@gordonwoodhull Well even though it's not specified in |
Yes, it indeed would cause issues. Let me see how to resolve it. |
Thanks! The dev ux of modern web app development with es modules is amazing and the tree shaking has huge potential in the dc.js/crossfilter/d3js setup. I'll gladly compare my example bundles when this is sorted out if you're interested. |
I created a sample open-wc app at https://github.com/nomego/dc-owc to highlight some ES6 issues with dc.js
First off is that just by doing
import { BarChart } from 'dc'
I get an error:So the d3-collection dep is missing from dc.js 4.2.5 but mandatory
The text was updated successfully, but these errors were encountered: