Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A flaw in the way keyAccessor is used in the scatterplot? #931

Closed
danse opened this issue May 6, 2015 · 2 comments
Closed

A flaw in the way keyAccessor is used in the scatterplot? #931

danse opened this issue May 6, 2015 · 2 comments

Comments

@danse
Copy link

danse commented May 6, 2015

I am trying to wrap my head around accessors and filtering in the scatterplot. When i read the code, i was surprised to find the key accessor used to extract the value for the y coordinate. Might this be the original sin leading to all the troubles? I would expect the value accessor to be used here, and the chart x and y accessors to grab either the first and second element in an array or the .x and .y properties in an object or whatever is defined by the user

@gordonwoodhull
Copy link
Contributor

Yes. This is #621

@danse
Copy link
Author

danse commented May 6, 2015

Thanks. Do i understand correctly that with this version of the code, if i override the key accessor to provide a value suitable for translate i will hamper indexing, while if i keep a key suitable for indexing i will break the scatterplot rendering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants