-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bubble chart padding #998
Comments
Should be calculated for each side independently. It can be put under a flag to make it backward compatible. |
Is there any reason for the clip-path? if it's a workaround only for me, I can set a post render and remove the clip-path on chart-body
|
That's a decent workaround for your case. We should consider making the clip path optional. I think it mainly exists to allow zooming of line and bar charts (#108) but zooming of bubble charts is also possible. I don't think eliminating the clip path is enough in all cases. If bubbles are really big they will still leave the chart area. |
It takes 3 lines with renderlet and no (visible) impact to add then remove clip-path. Not sure it's worthwhile adding an option to make the clip path optional. I've documented the workaround on SO, I'd say it's good enough ;) |
bubble padding is even more of an issue than scatter plot padding #440 because of the variable size of bubbles
It can be managed manually with
xAxisPadding
andyAxisPadding
but that's a lot of futzing.The text was updated successfully, but these errors were encountered: