From 4ee0146bed1a012a2f7fcb3d762634afbeeb10e3 Mon Sep 17 00:00:00 2001 From: deepak Date: Sat, 14 Apr 2018 23:56:35 +0530 Subject: [PATCH] Remove brush handles for scatter-plot --- spec/scatter-plot-spec.js | 5 +++++ src/scatter-plot.js | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/spec/scatter-plot-spec.js b/spec/scatter-plot-spec.js index 8688ac432..c3d929d52 100644 --- a/spec/scatter-plot-spec.js +++ b/spec/scatter-plot-spec.js @@ -234,6 +234,11 @@ describe('dc.scatterPlot', function () { chart.redraw(); }); + it('should not create brush handles', function () { + var selectAll = chart.select('g.brush').selectAll('path.custom-brush-handle'); + expect(selectAll.size()).toBe(0); + }); + it('should filter dimensions based on the same data', function () { jasmine.clock().tick(100); expect(otherDimension.top(Infinity).length).toBe(3); diff --git a/src/scatter-plot.js b/src/scatter-plot.js index bea0c75d2..14917b161 100644 --- a/src/scatter-plot.js +++ b/src/scatter-plot.js @@ -388,7 +388,7 @@ dc.scatterPlot = function (parent, chartGroup) { _symbol.size(oldSize); } - _chart.setHandlePaths = function () { + _chart.createBrushHandlePaths = function () { // no handle paths for poly-brushes };