Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryFactory leaves empty folders if there is a BinaryNotFound exception #117

Closed
kunalshetye opened this issue Apr 6, 2018 · 0 comments
Assignees
Labels

Comments

@kunalshetye
Copy link
Contributor

It is observed that BinaryFactory creates the directory and if there's a BinaryNotFound exception then it performs a cleanup by deleting the placeholder file but leaving the directory structure as is.

fileInfo.Directory.Create();

The problem is that if someones tries to malicious access the non-existing image urls (with a non-existing folder) they will end up creating a lot of empty folders which will never cleanup.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants