Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique ids broke relation lists preview #1198

Closed
Quicksaver opened this issue Mar 27, 2018 · 0 comments · Fixed by #1199
Closed

Unique ids broke relation lists preview #1198

Quicksaver opened this issue Mar 27, 2018 · 0 comments · Fixed by #1199

Comments

@Quicksaver
Copy link
Contributor

- Do you want to request a feature or report a bug?
bug

- What is the current behavior?
PR #1087 broke relation lists preview. Fix coming!

- If the current behavior is a bug, please provide the steps to reproduce.
This is hard, I stumbled upon it while testing locally. Haven't found any example in the demo that shows this. The ListControl component was using the forID property to check for metadata that has a structure like

{ "collection_name": { ... } }

but the changes to ensure forID uniqueness breaks this of course as the metadata doesn't have that unique string in the object's property names.

PR with fix coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant