Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug rendering preview component #420

Closed
lmcorreia opened this issue May 16, 2017 · 0 comments · Fixed by #421
Closed

Bug rendering preview component #420

lmcorreia opened this issue May 16, 2017 · 0 comments · Fixed by #421
Assignees

Comments

@lmcorreia
Copy link
Contributor

- Do you want to request a feature or report a bug?
BUG
- What is the current behavior?
An Uncaught Error is thrown while trying to load an entry after working on another (or the same) entry.
- If the current behavior is a bug, please provide the steps to reproduce.
Can be reproduced by checking out master at ab47c3c or newer:

  1. In the CMS, click an entry in any collection - the edit and preview panels will load
  2. Go back to the collections (Save the entry, Cancel, hit Home icon, ...)
  3. Click an entry again (same or other, doesn't matter) - check the Uncaught Error in the console:
Uncaught Error: PreviewPane.render(): A valid React element (or null) must be returned. You may have returned undefined, an array or some other invalid object.
    at invariant (cms.js:5654)
    at ReactCompositeComponentWrapper._renderValidatedComponent (cms.js:59635)
    at ReactCompositeComponentWrapper.performInitialMount (cms.js:59166)
    at ReactCompositeComponentWrapper.mountComponent (cms.js:59062)
    at Object.mountComponent (cms.js:14669)
    at ReactDOMComponent.mountChildren (cms.js:134890)
    at ReactDOMComponent._createInitialChildren (cms.js:132271)
    at ReactDOMComponent.mountComponent (cms.js:132090)
    at Object.mountComponent (cms.js:14669)
    at ReactDOMComponent.mountChildren (cms.js:134890)

- What is the expected behavior?
On step 3 above, for the entry to load as normal.

This seems to have been introduced in ab47c3c but I would appreciate some confirmation. I'm not familiar with React Frame component but if I can be of any help, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants