feat(netlify-cms-core): add lazy property to images in Media Library #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takeno
force-pushed
the
feat/lazy-images-media-library
branch
from
0e2c720
to
9e92167
Compare
martinjagodic
approved these changes
Apr 25, 2023
martinjagodic
pushed a commit
that referenced
this pull request
Oct 16, 2023
martinjagodic
pushed a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently when you open Media Library, all media insides are shown causing a lot of network requests even if you don't need them.
Using native image attribute
lazywill optimize images outside the viewport and reducing unused network requests.Test plan
There is not UI changes, just browser default behaviour and performance increased.
Checklist
yarn format.yarn test.