Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save fails silently if no title field is configured #690

Closed
erquhart opened this issue Oct 13, 2017 · 4 comments · Fixed by #1203
Closed

save fails silently if no title field is configured #690

erquhart opened this issue Oct 13, 2017 · 4 comments · Fixed by #1203

Comments

@erquhart
Copy link
Contributor

- Do you want to request a feature or report a bug?
bug
- What is the current behavior?
Saving fails silently if no title field is configured.

- If the current behavior is a bug, please provide the steps to reproduce.

  • configure a collection with a single field called "test"
  • enter text to the field
  • save the entry
  • observe error in console
  • observe no error in UI

- What is the expected behavior?
There should be an error in the UI.

- Please mention your CMS, node.js, and operating system version.
CMS 0.5.1

@tech4him1
Copy link
Contributor

I believe that this only occurs when the collection doesn't specify a custom slug, or the slug contains a {{slug}} part.

@tech4him1
Copy link
Contributor

@erquhart I wonder if the best way to do this for now, until we make slugs editable, would be to just fail on config loading (if create: true is set and there is not a title field, config is invalid).

@Benaiah Benaiah self-assigned this Nov 15, 2017
@erquhart
Copy link
Contributor Author

Yeah, it's better than silent failure.

@erquhart
Copy link
Contributor Author

erquhart commented Dec 9, 2017

Update: there is now an error in the UI, but it doesn't specifically tell the user how to fix. Still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants