Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change dayjs to per-package dependency #6992

Merged
merged 3 commits into from
Dec 19, 2023
Merged

fix: change dayjs to per-package dependency #6992

merged 3 commits into from
Dec 19, 2023

Conversation

martinjagodic
Copy link
Member

Dayjs is currently installed as a root package, but that creates a problem when installing decap-cms-app.

This PR removes it from root and adds it only to packages that need it.

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for decap-www canceled.

Name Link
🔨 Latest commit f62a41b
🔍 Latest deploy log https://app.netlify.com/sites/decap-www/deploys/658192ef544383000933c9e2

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for cms-demo ready!

Name Link
🔨 Latest commit 592bf3b
🔍 Latest deploy log https://app.netlify.com/sites/cms-demo/deploys/6560c31a5743e900088f627e
😎 Deploy Preview https://deploy-preview-6992--cms-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 24, 2023
demshy
demshy previously approved these changes Dec 19, 2023
@demshy demshy merged commit 0c278b0 into master Dec 19, 2023
16 of 17 checks passed
@demshy demshy deleted the fix-dayjs branch December 19, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants