Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI bugs in Firefox (Quantum) #907

Closed
2 tasks
DirtyF opened this issue Dec 9, 2017 · 9 comments · Fixed by #976
Closed
2 tasks

UI bugs in Firefox (Quantum) #907

DirtyF opened this issue Dec 9, 2017 · 9 comments · Fixed by #976

Comments

@DirtyF
Copy link
Contributor

DirtyF commented Dec 9, 2017

Congrats for shipping 1.0, here are some first sight issues that jump to my eyes in Firefox Quantum:

  • search icon position on inputs (collections, medias) 🦊 🍏

medias-search
collections-search

  • Editor toolbar switch button

editor-switch

@tech4him1
Copy link
Contributor

@DirtyF What browser are you using, the first two show up fine for me?

@DirtyF
Copy link
Contributor Author

DirtyF commented Dec 9, 2017

✅ Google Chrome, Safari
🐛 in Firefox 🦊 (MacOS High Sierra)

@tech4him1
Copy link
Contributor

Weird, I can reproduce that bug, but it almost seems like a Firefox bug -- if I try to change the positioning at all in the dev tools it starts showing up correctly with the setting the same.

@erquhart
Copy link
Contributor

erquhart commented Dec 9, 2017

It's due to changes in the way Quantum handles certain styling defaults.

@erquhart erquhart changed the title Polish UI UI bugs in Firefox (Quantum) Dec 9, 2017
@tech4him1
Copy link
Contributor

tech4him1 commented Dec 9, 2017

@DirtyF The third bug in your list is a duplicate of #684, right? And I think the fourth issue could be split off since it isn't really 1.0 specific.

@DirtyF
Copy link
Contributor Author

DirtyF commented Dec 10, 2017

@tech4him1 splitted ✂️

@erquhart
Copy link
Contributor

erquhart commented Dec 19, 2017

Note: these are all issues where Firefox is not applying default top/left for absolute positioned items appropriately. If you toggle absolute positioning off and on for these items in FF dev tools, they correctly apply default positioning. A quick scan of recent entries in bugzilla shows a few issues that could match, so we should determine which is the cause, or open one.

For our immediate purposes, I'm okay with accepting a workaround PR.

@tech4him1
Copy link
Contributor

Maybe https://bugzilla.mozilla.org/show_bug.cgi?id=1386654 or https://bugzilla.mozilla.org/show_bug.cgi?id=1417025?

@erquhart
Copy link
Contributor

erquhart commented Dec 24, 2017

Yeah those were the two I saw, and they're both so closely related, I'm betting it's all the same underlying issue. Thanks for linking those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants