Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix babel-preset-env." #1129

Merged
merged 4 commits into from
Feb 27, 2018
Merged

Revert "Fix babel-preset-env." #1129

merged 4 commits into from
Feb 27, 2018

Conversation

tech4him1
Copy link
Contributor

@tech4him1 tech4him1 commented Feb 21, 2018

Reverts #765

This reverts our build back to ES5 (needed for #1097).

@tech4him1 tech4him1 requested a review from erquhart February 21, 2018 23:06
@tech4him1
Copy link
Contributor Author

ping @erquhart

@verythorough
Copy link
Contributor

verythorough commented Feb 21, 2018

Deploy preview for netlify-cms-www ready!

Built with commit a64972a

https://deploy-preview-1129--netlify-cms-www.netlify.com

@verythorough
Copy link
Contributor

verythorough commented Feb 21, 2018

Deploy preview for cms-demo ready!

Built with commit a64972a

https://deploy-preview-1129--cms-demo.netlify.com

@tech4him1 tech4him1 removed the request for review from erquhart February 21, 2018 23:13
@tech4him1
Copy link
Contributor Author

@erquhart This can go on top of your last PR, it was just intended to remove the Babel warnings ("suggestions") to use the env preset. It transpiles all the way back to ES5, since there are no targets listed in env.

@tech4him1 tech4him1 requested a review from erquhart February 27, 2018 17:17
@tech4him1
Copy link
Contributor Author

@erquhart Are you still wanting to merge this?

Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tech4him1 tech4him1 merged commit ab7c1b6 into master Feb 27, 2018
@tech4him1 tech4him1 deleted the revert-765-fix-es6 branch February 27, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants